014: Zen and the Art of Pull Requests

Ben has "feelings" about many aspects of web application development. And, after working with git and GitHub for the last 10-years, he's formed a lot of strong opinions - oftentimes strongly held - about how Pull Requests (PRs) should be created and managed within a team context. For example:

Code completed is more important than code being written. As such, if an open PR sits around for more than an hour, your team has failed to review said PR in a timely manner.

And:

If a PR takes more than 15-minutes to review, the PR is too large. The author of said PR has failed to decompose the problem into smaller, independently-deployable changes.

As you can imagine, Ben's "PR Commandments" don't work for every one or every team. This week, the crew meets to discuss his approach to Pull Requests, reaching consensus on some concepts and pushing-back strongly on others. And, of course, this is totally fine - every team has its own set of constraints that have bearing on how that team operates. Your mileage my vary!

Plus, we find out that Carol can be bribed with tacos... sweet, sweet tacos!

Triumphs & Failures

Notes & Links

Follow the show! Our website is workingcode.dev and we're @WorkingCodePod on Twitter and Instagram. New episodes weekly on Wednesday.

And, if you're feeling the love, support us on Patreon.

next episode: 015: Potluck #1

prev episode: 013: Do What You Love and You'll Never Work a Day In Your Life